[CodingStyle] Deprecate EnumCaseToPascalCaseRector as risky change#8095
Merged
Conversation
It does not handle enum usage across the whole context. Better handled via IDE with full context, manually, or a custom rule.
Contributor
|
I actually really like this and use it... |
Member
Author
|
Still dangerous, as it does not update all references. Similar to rectorphp/rector#8439 |
Contributor
|
Can you not just put it into a "Risky Rules" set that has to be opted in so that it's clear it's risky? |
Member
Author
|
That would make little sense, as we group by domain and want to provide deterministic rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
EnumCaseToPascalCaseRector.The rule renames enum cases to PascalCase, but it cannot reliably track every usage of an enum case across the whole context. That makes it a risky change with little value.
Better handled via IDE with full context, manually, or a custom rule where needed.